[
https://issues.apache.org/jira/browse/CASSANDRA-17733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564739#comment-17564739
]
Ekaterina Dimitrova commented on CASSANDRA-17733:
-------------------------------------------------
Thank you [~marcuse] , I just went ahead and changed it as it was rather quick
patch. Can you, please, review it?
I changed also the set/get methods' names in the DatabaseDescriptor to
acknowledge that internally we operate the property in bytes.
Also, added NEWS.txt and CHANGES.txt entries.
[4.1 branch|https://github.com/ekaterinadimitrova2/cassandra/tree/17733-4.1]. -
[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17733-4.1&filter=all]
[trunk
branch|https://github.com/ekaterinadimitrova2/cassandra/tree/17733-trunk] -
[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17733-trunk&filter=all]
> min_tracked_partition_size_bytes should not have the suffix prefix
> ------------------------------------------------------------------
>
> Key: CASSANDRA-17733
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17733
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.1-beta, 4.x
>
>
> min_tracked_partition_size_bytes was added in CASSANDRA-16310. It should have
> not been added with the unit suffix anymore as confirmed on the commit.
> It is also confusing now when users can add unit of their choice.
> We have two options:
> * keep it with annotation and add also version without the suffix
> * rename it as we are still alpha and API changes can be done for bug
> fixing. Not sure whether we need an approval on the ML for this one.
> CC [~ycai] , [~marcuse] and [~dcapwell]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
