[ https://issues.apache.org/jira/browse/CASSANDRA-17314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569720#comment-17569720 ]
Runtian Liu commented on CASSANDRA-17314: ----------------------------------------- I think this is only broken in 3.0. The fix is mostly borrowed from 3.11/4.0 code. The bug in 3.0 is that when throwing error [here|https://github.com/apache/cassandra/pull/1707/files#diff-34814e77850d8cdcae4e28d7edb14ae7a3052c2e28101ca7c347687fc427670aR122], the checksum is not reset. We need to reset checksum every time we try to compare. 3.11 and 4.0 has the function to calculate the checksum. Also, we need to clear the buffer to make sure the reader doesn't see stale data. 4.0 has similar code [here|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/util/CompressedChunkReader.java#L165]. > Test Failure: org.apache.cassandra.db.ScrubTest.testScrubCorruptedCounterRow > ---------------------------------------------------------------------------- > > Key: CASSANDRA-17314 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17314 > Project: Cassandra > Issue Type: Bug > Components: Test/unit > Reporter: Josh McKenzie > Assignee: Runtian Liu > Priority: Normal > Fix For: 3.0.x > > > Failed 10 times in the last 14 runs. Flakiness: 61%, Stability: 28% > Error Message > Timeout occurred. Please note the time in the report does not reflect the > time until the timeout. > {code} > Stacktrace > junit.framework.AssertionFailedError: Timeout occurred. Please note the time > in the report does not reflect the time until the timeout. > at java.util.Vector.forEach(Vector.java:1277) > at java.util.Vector.forEach(Vector.java:1277) > at java.util.Vector.forEach(Vector.java:1277) > at jdk.nashorn.internal.scripts.Script$3$\^eval\_.:program(<eval>:13) > at > jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:637) > at > jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:494) > at > jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:393) > at > jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:449) > at > jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:406) > at > jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:402) > at > jdk.nashorn.api.scripting.NashornScriptEngine.eval(NashornScriptEngine.java:155) > at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:264) > at java.util.Vector.forEach(Vector.java:1277) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org