[
https://issues.apache.org/jira/browse/CASSANDRA-17768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570296#comment-17570296
]
Benedict Elliott Smith commented on CASSANDRA-17768:
----------------------------------------------------
So, looking back, TCP layer keep alive was being specified back when this patch
was introduced. But perhaps it wasn't in an earlier build that encountered this
behaviour? There's no discussion on the original ticket around why TCP layer
keep alive wasn't working.
So far 4.0 has been running without application layer keep alive, seemingly
just fine. Do we have any evidence this is still needed, [~paulo]?
> streaming_keep_alive_period is not used after [CASSANDRA-16927] CEP-10 Phase
> 1: Refactor Streaming
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17768
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17768
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Streaming and Messaging
> Reporter: Ekaterina Dimitrova
> Assignee: Aleksey Yeschenko
> Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> While working on another ticket I noticed that after [CASSANDRA-16927] CEP-10
> Phase 1: Refactor Streaming
> streaming_keep_alive_period is not used anymore, except to print it in error
> message
> [here|https://github.com/apache/cassandra/blob/cassandra-4.1/src/java/org/apache/cassandra/streaming/StreamSession.java#L689]
> If the property should not be used anymore, we need to deprecate it and fix
> the error message as it is misleading.
> [~benedict] , [~samt] , [~aleksey] , can you, please, check and take care of
> this one as authors of that patch?
> Thank you in advance!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
