[
https://issues.apache.org/jira/browse/CASSANDRA-17782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Doug Rohrer updated CASSANDRA-17782:
------------------------------------
Authors: Doug Rohrer
Test and Documentation Plan: Tested by removing the call to
{{setDefaultFailureDetector}} from {{{}CQLSSTableWriterClientTest{}}}.
Status: Patch Available (was: Open)
{{Index:
test/unit/org/apache/cassandra/io/sstable/CQLSSTableWriterClientTest.java}}
{{IDEA additional info:}}
{{Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP}}
{{<+>UTF-8}}
{{===================================================================}}
{{diff --git
a/test/unit/org/apache/cassandra/io/sstable/CQLSSTableWriterClientTest.java
b/test/unit/org/apache/cassandra/io/sstable/CQLSSTableWriterClientTest.java}}
{{---
a/test/unit/org/apache/cassandra/io/sstable/CQLSSTableWriterClientTest.java
(revision ea03af460511442e771ddd704d92568a63557686)}}
{{+++
b/test/unit/org/apache/cassandra/io/sstable/CQLSSTableWriterClientTest.java
(date 1659033276652)}}
{{@@ -41,7 +41,6 @@}}
{{ public void setUp()}}
{{ {}}
{{ this.testDirectory = new File(Files.createTempDir());}}
{{- DatabaseDescriptor.setDefaultFailureDetector();}}
{{ DatabaseDescriptor.clientInitialization();}}
{{ }}}
{{Index: src/java/org/apache/cassandra/config/DatabaseDescriptor.java}}
{{IDEA additional info:}}
{{Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP}}
{{<+>UTF-8}}
{{===================================================================}}
{{diff --git a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java}}
{{--- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java (revision
ea03af460511442e771ddd704d92568a63557686)}}
{{+++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java (date
1659363546751)}}
{{@@ -281,7 +281,7 @@}}
{{ if (clientInitialized)}}
{{ return;}}
{{ clientInitialized = true;}}
{{-}}
{{+ setDefaultFailureDetector();}}
{{ Config.setClientMode(true);}}
{{ conf = new Config();}}
{{ diskOptimizationStrategy = new SpinningDiskOptimizationStrategy();}}
> `DatabaseDescriptor#clientInitialization` should set the `newFailureDetector`
> (maybe to a NoOpFailureDetector?)
> ---------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17782
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17782
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Startup and Shutdown
> Reporter: Doug Rohrer
> Priority: Normal
> Fix For: 4.1.x
>
>
> With the introduction of a configurable FailureDetector, client users of the
> {{cassandra-all}} jar now need to call not just `clientInitialization` but
> also `setDefaultFailureDetector` in order to avoid an NPE when the failure
> detector is constructed. This is a breaking change from previous versions
> where this was not necessary.
> Calls to {{DatabaseDescriptor#clientInitialization}} should set
> {{newFailureDetector}} to +something+, either by calling
> {{setDefaultFailureDetector}} or creating a different (NoOp?) FailureDetector.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
