[
https://issues.apache.org/jira/browse/CASSANDRA-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-17725:
--------------------------------------------
Fix Version/s: 4.1
(was: 4.x)
Since Version: 4.1-alpha1
Source Control Link:
https://github.com/apache/cassandra/commit/dd08314ed654aafa60b2a82fc4953aac171ba3ef
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Add a flag for throughput in MiB/s for nodetool setstreamthroughput,
> getstreamthroughput, setinterdcstreamthroughput and
> getinterdcstreamthroughput
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17725
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17725
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.1-beta, 4.1
>
>
> As we agreed not to add new JMX methods for the new config on the mailing
> list, we need at least new flags for setstreamthroughput and
> interdcstreamthroughput for the two 4.0 parameters to be set/get also in MiB,
> not only in megabits.
> Thus we will have the option either to use the old version for those 2, or to
> be able to set/get in MiB all 4 streaming parameters. As of 4.1 supported
> units for DataRateSpec are MiB/s, B/s, KiB/s, megabit is only for legacy from
> 4.0 - backward compatibility.
> To be sure we satisfy the requirements around the latest discussions about
> backward compatibility in tools, I will use this ticket also to make a final
> pass on the unit changes done, to ensure the probe output is not affected.
> ----
> Final patch consists of:
> - Uncomment prepared_statements_cache_size, key_cache_size,
> counter_cache_size, index_summary_capacity which were
> commented out by mistake in a previous patch
> - Fix breaking change with cache_load_timeout; cache_load_timeout_seconds <=0
> and cache_load_timeout=0 are equivalent
> and they both mean disabled
> - Deprecate public method setRate(final double throughputMbPerSec) in
> Compaction Manager in favor of
> setRateInBytes(final double throughputBytesPerSec)
> - Revert breaking change removal of
> StressCQLSSTableWriter.Builder.withBufferSizeInMB(int size). Deprecate it in
> favor
> of StressCQLSSTableWriter.Builder.withBufferSizeInMiB(int size)
> - Fix precision issues, add new -m flag (for nodetool/setstreamthroughput,
> nodetool/setinterdcstreamthroughput,
> nodetool/getstreamthroughput and nodetoo/getinterdcstreamthroughput), add new
> -d flags (nodetool/getstreamthroughput, nodetool/getinterdcstreamthroughput,
> nodetool/getcompactionthroughput)
> - Fix a bug with precision in nodetool/compactionstats
> - Deprecate StorageService methods and add new ones for
> stream_throughput_outbound, inter_dc_stream_throughput_outbound,
> compaction_throughput_outbound in the JMX MBean
> `org.apache.cassandra.db:type=StorageService`
> - Removed getEntireSSTableStreamThroughputMebibytesPerSec in favor of new
> getEntireSSTableStreamThroughputMebibytesPerSecAsDouble
> in the JMX MBean `org.apache.cassandra.db:type=StorageService`
> - Removed getEntireSSTableInterDCStreamThroughputMebibytesPerSec in favor of
> getEntireSSTableInterDCStreamThroughputMebibytesPerSecAsDouble
> in the JMX MBean `org.apache.cassandra.db:type=StorageService`
> It is the same for 4.1 and trunk
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
