[
https://issues.apache.org/jira/browse/CASSANDRA-17679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575357#comment-17575357
]
Josh McKenzie commented on CASSANDRA-17679:
-------------------------------------------
bq. All the patch here seems to do is skip looking at the already streamed
ranges, which has the exact same effect as deleting the ranges from the system
table
Correct. This patch is an attempt at a minimal / surgical "hard disable
resumable bootstrap via a system param", not realizing there was already an
undocumented param that did this (the perils of upstreaming + -D params... ;)).
[~paulo] pushed for disabling by default and removing later which I'm amenable
to but not necessarily advocating for.
100% agree on having duplicate flags and functionality being Bad; appreciate
you pointing that out as I wasn't aware that was in the system. We should
continue to support this flag and consider promoting it to the .yaml and
document it + NEWS.txt it to better surface the ability to cleanly disable this
functionality.
So a snapshot of where we are right now:
* the patch here largely duplicates the effect of
-Dcassandra.reset_bootstrap_progress by just ignoring the resuming query
entirely, and should thus be scrapped in favor of the existing param + logic
* we should probably be more aggressive about deleting the incomplete bootstrap
data on disk in the event of a failed / restarted bootstrap
w/cassandra.reset_bootstrap_progress set to true
* it's up for debate as to whether we want to change this default or not
That about cover it?
> Make resumable bootstrap feature optional
> -----------------------------------------
>
> Key: CASSANDRA-17679
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17679
> Project: Cassandra
> Issue Type: New Feature
> Components: Consistency/Streaming
> Reporter: Josh McKenzie
> Assignee: Josh McKenzie
> Priority: Normal
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> From the patch I'm working on:
> {code}
> # In certain environments, operators may want to disable resumable bootstrap
> in order to avoid potential correctness
> # violations or data loss scenarios. Largely this centers around nodes going
> down during bootstrap, tombstones being
> # written, and potential races with repair. By default we leave this on as
> it's been enabled for quite some time,
> # however the option to disable it is more palatable now that we have zero
> copy streaming as that greatly accelerates
> # bootstraps. This defaults to true.
> # resumable_bootstrap_enabled: true
> {code}
> Not really a great fit for guardrails as it's less a "feature to be toggled
> on and off" and more a subset of a specific feature that in certain
> circumstances can lead to issues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
