[
https://issues.apache.org/jira/browse/CASSANDRA-17792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578617#comment-17578617
]
Yifan Cai commented on CASSANDRA-17792:
---------------------------------------
Thank you for reviewing! I updated the JIRA title to reflect the fix.
> Fix race condition on updating cdc size and advancing to next segment
> ---------------------------------------------------------------------
>
> Key: CASSANDRA-17792
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17792
> Project: Cassandra
> Issue Type: Bug
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Yifan Cai
> Priority: Normal
> Fix For: 4.x
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> org.apache.cassandra.distributed.test.cdc.ToggleCDCOnRepairEnabledTest is a
> bit flaky on [trunk.
> As [this
> run|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17666]
> shows it was flaky since it was introduced a month ago as part of
> CASSANDRA-17666 but the flakiness is so low that if we don't run it in a loop
> it is hard to hit it.
> Both tests in the test class can fail with the same exception:
> {code:java}
> org.apache.cassandra.distributed.shared.ShutdownException: Uncaught
> exceptions were thrown during test at
> org.apache.cassandra.distributed.impl.AbstractCluster.checkAndResetUncaughtExceptions(AbstractCluster.java:1056)
> at
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1042)
> at
> org.apache.cassandra.distributed.test.cdc.ToggleCDCOnRepairEnabledTest.testCDCOnRepairEnabled(ToggleCDCOnRepairEnabledTest.java:95)
> at
> org.apache.cassandra.distributed.test.cdc.ToggleCDCOnRepairEnabledTest.testCDCOnRepairIsEnabled(ToggleCDCOnRepairEnabledTest.java:40)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Suppressed: java.lang.NullPointerException at
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.recalculateOverflowSize(CommitLogSegmentManagerCDC.java:390)
> at org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:81) at
> org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:47) at
> org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:57) at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.base/java.lang.Thread.run(Thread.java:829){code}
> CC [~ycai] , [~jmckenzie]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
