[
https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578817#comment-17578817
]
Abe Ratnofsky edited comment on CASSANDRA-17753 at 8/12/22 5:52 AM:
--------------------------------------------------------------------
[~mck] I'm trying to repro the situation above and just want to make sure I
have things right: first, create -src and -bin release tarballs with `ant
artifacts`, then unzip. In the case of -src, run `ant` to build.
In -bin, the version.properties file is built into the JAR in the tar. In -src,
this file is excluded:
[https://github.com/apache/cassandra/blob/a45e70a860e9d68745f463f5a06aa7b870ff69df/build.xml#L1321]
Is that what you're referring to? I can't find the situation where the file is
present, but GitSHA is empty, as you described.
Once I can get the version.properties file built into the tarballs, I'm
planning to change the behavior a bit so that if Git is available (as an
executable and within a repo) and version.properties is present, it is
regenerated, but if Git is not available, then the existing version.properties
is used. This way, release tarballs without Git will have the file pre-filled
and work as intended. If Git is not available, the file will be set with
Unknown values.
was (Author: aratnofsky):
[~mck] I'm trying to repro the situation above and just want to make sure I
have things right: first, create -src and -bin release tarballs with `ant
artifacts`, then unzip. In the case of -src, run `ant` to build.
In -bin, the version.properties file is built into the JAR in the tar. In -src,
this file is excluded:
[https://github.com/apache/cassandra/blob/a45e70a860e9d68745f463f5a06aa7b870ff69df/build.xml#L1321]
Is that what you're referring to? I can find the situation where the file is
present, but GitSHA is empty, as you described.
Once I can get the version.properties file built into the tarballs, I'm
planning to change the behavior a bit so that if Git is available (as an
executable and within a repo) and version.properties is present, it is
regenerated, but if Git is not available, then the existing version.properties
is used. This way, release tarballs without Git will have the file pre-filled
and work as intended. If Git is not available, the file will be set with
Unknown values.
> Include GitSHA in nodetool version output
> -----------------------------------------
>
> Key: CASSANDRA-17753
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17753
> Project: Cassandra
> Issue Type: New Feature
> Components: Tool/nodetool
> Reporter: Abe Ratnofsky
> Assignee: Abe Ratnofsky
> Priority: Normal
> Fix For: 4.x
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> It can be useful to see specifically which Git SHA a running instance of
> Cassandra was built with, especially when running clusters in development for
> soak testing.
>
> I have a patch ready for this, and am preparing it now.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
