[
https://issues.apache.org/jira/browse/CASSANDRA-17668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608916#comment-17608916
]
Ekaterina Dimitrova edited comment on CASSANDRA-17668 at 9/23/22 10:24 PM:
---------------------------------------------------------------------------
Hi [~lmtrombone] ,
I agree with your analysis plus I am adding the following to confirm your patch
has nothing to do with the failures we saw:
*
[test_no_base_column_in_view_pk_complex_timestamp_with_flush|https://jenkins-cm4.apache.org/view/patches/job/Cassandra-devbranch/1913/testReport/junit/dtest.materialized_views_test/TestMaterializedViews/test_no_base_column_in_view_pk_complex_timestamp_with_flush/]
- I fixed this one already in another ticket
* testMetricsWithRepairAndStreamingToTwoNodes – seen in CASSANDRA-17608
* badHeader - CASSANDRA-17488
* forceWitDifference - seen in CASSANDRA-17566
As it's been some time since we ran that CI, I just did a
[rebase|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-17668]
and started final [CI
run|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=CASSANDRA-17668].
I will check that one later and commit, overall I do not expect surprises.
was (Author: e.dimitrova):
Hi [~lmtrombone] ,
I agree with your analysis plus I am adding the following to confirm your patch
has nothing to do with the failures we saw:
*
[test_no_base_column_in_view_pk_complex_timestamp_with_flush|https://jenkins-cm4.apache.org/view/patches/job/Cassandra-devbranch/1913/testReport/junit/dtest.materialized_views_test/TestMaterializedViews/test_no_base_column_in_view_pk_complex_timestamp_with_flush/]
- I fixed this one already in another ticket
* testMetricsWithRepairAndStreamingToTwoNodes – seen in CASSANDRA-17608
* badHeader - CASSANDRA-17488
* forceWitDifference - seen in CASSANDRA-17566
As it's been some time since we ran that CI, I just did a
[rebase|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-17668]
and started final [CI
run|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=CASSANDRA-17668].
I will check that one later and commit, I do not expect surprises.
> Fix leak of non-standard Java types in our Exceptions as clients using JMX
> are unable to handle them
> ----------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17668
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17668
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Observability, Observability/JMX
> Reporter: Ekaterina Dimitrova
> Assignee: Leonard Ma
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x
>
> Attachments: Screen Shot 2022-09-13 at 11.27.30 PM.png
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> This is a continuation of CASSANDRA-17638 where we fixed leaks introduced
> during development of 4.1 to ensure no regressions.
> This ticket is to fix a few leakages which are there since previous major
> versions, not 4.1 regressions.
> {_}setRepairSessionMaxTreeDepth{_}(exists since 3.0) and
> _setRepairSessionSpaceInMegabytes(since 4.0)_
> in the DatabaseDescriptor.
> checkValidForByteConversion and _validateMaxConcurrentAutoUpgradeTasksConf
> (both since 4.0)_
> are used in both setters and on startup. They shouldn't throw
> ConfigurationException in the setters.
> There might be more but those are at least a few obvious I found in the
> DatabaseDescriptor.
> CC [~dcapwell]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
