[ https://issues.apache.org/jira/browse/CASSANDRA-17870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609606#comment-17609606 ]
Francisco Guerrero commented on CASSANDRA-17870: ------------------------------------------------ {quote} Why prefer excluding the local DC instead of setting a source DC? {quote} [~yifanc] This would be for the case where you are building out a new DC, and your local [new] DC nodes do not have data yet. There's already a way to specify a *{{src-dc-name}}* (which can be the local DC) [see|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/Rebuild.java#L30]. > nodetool/rebuild: Add flag to exclude nodes from local datacenter > ----------------------------------------------------------------- > > Key: CASSANDRA-17870 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17870 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool > Reporter: Saranya Krishnakumar > Assignee: Saranya Krishnakumar > Priority: Normal > Attachments: fix_nodetool_rebuild.diff > > > During expansion by Dc, when we issue nodetool/rebuild from new dc to rebuild > the data from other DCs. If src-dc is not passed explicitly, then C* tries to > rebuild the data from the same (new dc) dc. > We don’t exclude other nodes in the same DC. Only down sources and the local > node itself are excluded. > ``` > // We're _always_ filtering out a local node and down sources > addSourceFilter(new > RangeStreamer.FailureDetectorSourceFilter(failureDetector)); > addSourceFilter(new RangeStreamer.ExcludeLocalNodeFilter()); > ``` > We should fix nodetool/rebuild to exclude the local DC (from where we’re > executing the command) while issuing nodetool/rebuild without passing src dc -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org