[ 
https://issues.apache.org/jira/browse/CASSANDRA-17221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610280#comment-17610280
 ] 

Ekaterina Dimitrova commented on CASSANDRA-17221:
-------------------------------------------------

[~xvade], after some recent changes in CASSANDRA-17750 adding dependencies 
happens out of build.xml.
It seems during rebase the previously added dependency got lost and the code is 
not compiling.
I added the dependency 
[here|https://github.com/ekaterinadimitrova2/cassandra/tree/math_fcts_review] 
as per the new instructions, unfortunately they are still in review 
[here|https://github.com/apache/cassandra-website/pull/170/files] but I am 
linking the commit for your reference if you are curious to see what changed.

Feel free to cherry-pick the last commit on that branch.

On a very quick skim I didn't see anything else lost during rebase, code-wise.

Unfortunately, our discussions got lost somewhere down the road but I will try 
to look at it one more time with fresh eyes. For now, leaving it to Benjamin, 
let's see what he as an expert in that area has to say :)  

> Add Math functions 
> -------------------
>
>                 Key: CASSANDRA-17221
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17221
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL/Syntax
>            Reporter: Benjamin Lerer
>            Assignee: Simon Chess
>            Priority: Normal
>              Labels: AdventCalendar2021, lhf
>             Fix For: 4.x
>
>
> We should add native Maths functions for the most common operations:
> * {{abs\(x)}} returns the absolute value of the x
> * {{exp\(x)}} returns the value of e (the base of natural logarithms) raised 
> to the power of x
> * {{log\(x)}} returns the natural logarithm (base e) of x
> * {{log10\(x)}} returns the base-10 logarithm of x
> * {{round\(x)}} returns the closest integer to x
> +Additional information for newcomers:+
> The new functions should be put in a new class {{MathFcts}} similar to 
> {{TimeFcts}}.
> The {{MathsFcts.all()}} method should be called in 
> {{SystemKeyspace.functions}}
> The unit tests for the functions should be put in a {{MathFctsTest}} similar 
> to {{TimeFctsTest}} 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to