[ 
https://issues.apache.org/jira/browse/CASSANDRA-17879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610354#comment-17610354
 ] 

Stefan Miklosovic edited comment on CASSANDRA-17879 at 9/28/22 5:41 AM:
------------------------------------------------------------------------

Thanks [~bschoeni] for the patch.

I tried it and the issues I ran into were:

1) it stopped to work when the primary key was composite, if primary key was 
just a simple column, "(mycolumn)", it autocompleted "WITH". But as soon as the 
key was "((col1), col2)" and I wanted to autocomplete "WITH CLUSTERING ORDER BY 
(col2 DESC);" it did not offer "WITH".

2) I was expecting that it will offer me all properties which I can use for 
regular tables. For example, "WITH comment = 'this is my view'" or any other 
property for that matter. 

For 2), this is where I am not completely sure if we are doing the right thing. 
Are mv allowed to go wild with other properties? Like you can have one 
gc_grace_seconds for base table but other for a mv? What does that mean in 
practice? Or compression, compaction and so on ... that's why I asked 
[~brandon.williams] if this makes sense to add into mv too. 


was (Author: smiklosovic):
Thanks [~bschoeni] for the patch.

I tried it and the issues I ran into were:

1) it stopped to work when the primary key was composite, if primary key was 
just a simple column, "(mycolumn)", it autocompleted "WITH". But as soon as the 
key was "((col1), col2)" and I wanted to autocomplete "WITH CLUSTERING ORDER BY 
(col2 DESC);" it did not offer "WITH".

2) I was expecting that it will offer me all properties which I can use for 
regular tables. For example, "WITH comment = 'this is my view'" or any other 
property for that matter. 

For 2), this is where I am not completely sure if we are doing the right thing. 
Are mv allowed to go wild with other properties? Like you can have one 
gc_grace_seconds for base table but other from mv? What does that mean in 
practice? Or compression, compaction and so on ... that's why I asked 
[~brandon.williams] if this makes sense to add into mv too. 

> It is not possible to autocomplete "WITH" when creating materialized view
> -------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17879
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17879
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL/Interpreter
>            Reporter: Stefan Miklosovic
>            Assignee: Brad Schoening
>            Priority: Normal
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I noticed that when I type this:
> {code}
> CREATE MATERIALIZED VIEW ks.mv2 AS SELECT * FROM t WHERE k IS NOT NULL AND c1 
> IS NOT NULL AND c2 IS NOT NULL PRIMARY KEY (c1,k,c2) <TAB>
> {code}
> nothing happens after pressing tab, there should be options shown as for 
> table case.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to