[ https://issues.apache.org/jira/browse/CASSANDRA-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080484#comment-13080484 ]
paul cannon commented on CASSANDRA-2785: ---------------------------------------- I think this patch is still correct, and that the bug causing the regression was the invalid hard-coding of JAVA_HOME in redhat/cassandra. If the fix for CASSANDRA-2992 is acceptable, this should probably be re-closed as well. > should export JAVA variable in the bin/cassandra and use that in the > cassandra-env.sh when check for the java version > --------------------------------------------------------------------------------------------------------------------- > > Key: CASSANDRA-2785 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2785 > Project: Cassandra > Issue Type: Bug > Reporter: Jackson Chung > Assignee: paul cannon > Attachments: 0001-use-JAVA-in-cassandra-env.sh.patch.txt, > 0002-fix-usage-of-bash-n-tests.patch.txt > > > I forgot which jira we add this java -version check in the cassandra-env.sh > (for adding jamm to the javaagent), but we should probably use the variable > JAVA set in bin/cassandra (will need export) and use $JAVA instead of "java" > in the cassandra-env.sh > In a situation where JAVA_HOME may have been properly set as the Sun's java > but the PATH still have the OpenJDK's java in front, the check will fail to > add the jamm.jar, even though the cassandra jvm is properly started via the > Sun's java. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira