[
https://issues.apache.org/jira/browse/CASSANDRA-14227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610845#comment-17610845
]
Berenguer Blasi commented on CASSANDRA-14227:
---------------------------------------------
Hi,
moving to this to review. Some comments:
- Max TTL is now 68y and there is a new default NONE overflow policy, the other
ones are kept for backwards compatibility.
- All tests pass but for one upgrade rolling failing 10% of times. I am
investigating it but given it is taking a lot of time and I can't repro lcoally
I prefer to start with the review already.
- The code has a few 'TODO 14227' comments which are points I would like to
discuss with the reviewer such as
{{StreamingTombstoneHistogramBuilder#mergeNearestPoints()}}
- Most files only change int to longs, think about sentinel values while
reviewing and possible side-effects
- The PR has a few self-contained commits for an easier review.
> Extend maximum expiration date
> ------------------------------
>
> Key: CASSANDRA-14227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14227
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
> Reporter: Paulo Motta (Deprecated)
> Assignee: Berenguer Blasi
> Priority: Urgent
> Fix For: 4.x
>
>
> The maximum expiration timestamp that can be represented by the storage
> engine is
> 2038-01-19T03:14:06+00:00 due to the encoding of {{localExpirationTime}} as
> an int32.
> On CASSANDRA-14092 we added an overflow policy which rejects requests with
> expiration above the maximum date as a temporary measure, but we should
> remove this limitation by updating the storage engine to support at least the
> maximum allowed TTL of 20 years.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
