[
https://issues.apache.org/jira/browse/CASSANDRA-16681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-16681:
------------------------------------------
Status: Ready to Commit (was: Review In Progress)
May I suggest that we only commit the first 6 out of 7 changes, without the
simplification patch?
It’s not incorrect, it does address the (non-critical) issue of returning fully
freed chunks to the partially recycled queue, but in my opinion it’s not
definitively significantly simpler enough to justify.
It shifts some of the existing complexity to {{Chunk}} but the coupling with LP
recycling logic remains effectively the same, and I’m not the biggest fan of
{{recycleFully()}} essentially having to be aware of the call stack to decide
which CAS to do.
Do you mind delaying further simplification until a further refactor, in a
different ticket, that would also include a {{LocalPool}} refactor wrt handling
of the tiny pool?
If you don’t mind, then I’m +1 to commit the initial 6 patches and consider the
ticket resolved. Cheers.
> org.apache.cassandra.utils.memory.LongBufferPoolTest - tests are flaky
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-16681
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16681
> Project: Cassandra
> Issue Type: Bug
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Piotr Kolaczkowski
> Priority: Normal
> Fix For: 3.11.x, 4.0.x, 4.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Jenkins history:
> [https://jenkins-cm4.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.utils.memory/LongBufferPoolTest/testPoolAllocateWithRecyclePartially/history/]
> Fails being run in a loop in CircleCI:
> https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/844/workflows/945011f4-00ac-4678-89f6-5c0db0a40169/jobs/5008
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
