[ https://issues.apache.org/jira/browse/CASSANDRA-17927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17612818#comment-17612818 ]
Caleb Rackliffe edited comment on CASSANDRA-17927 at 10/5/22 4:51 PM: ---------------------------------------------------------------------- It looks like the legacy native protocol server logic doesn't guarantee that the bytes-in-flight release occurs before client response. (See {{PreV5Handlers.LegacyDispatchHandler.releaseItem()}}) I've just adjusted that assumption in the test. Multiplexer run in progress... |4.1|[patch|https://github.com/apache/cassandra/pull/1898]|[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra?branch=CASSANDRA-17927-4.1]| |trunk|[patch|https://github.com/apache/cassandra/pull/1901]|[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra?branch=CASSANDRA-17927-trunk]| was (Author: maedhroz): It looks like the legacy native protocol server logic doesn't guarantee that the bytes-in-flight release occurs before client response. (See {{PreV5Handlers.LegacyDispatchHandler.releaseItem()}}) I've just adjusted that assumption in the test. Multiplexer run in progress... https://github.com/apache/cassandra/pull/1898 > Test Failure: > org.apache.cassandra.transport.RateLimitingTest.shouldThrowOnOverloadSmallMessages[4/v4]-cdc > > ----------------------------------------------------------------------------------------------------------- > > Key: CASSANDRA-17927 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17927 > Project: Cassandra > Issue Type: Bug > Components: Test/unit > Reporter: Josh McKenzie > Assignee: Caleb Rackliffe > Priority: Normal > Fix For: 4.1-beta, 4.2 > > > [Link|https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/org.apache.cassandra.transport/RateLimitingTest/shouldThrowOnOverloadSmallMessages_4_v4__cdc/] > Failed 1 times in the last 30 runs. Flakiness: 6%, Stability: 96% > Error Message > expected:<0> but was:<316> > StackTrace > {code:java} > junit.framework.AssertionFailedError: expected:<0> but was:<316> > at > org.apache.cassandra.transport.RateLimitingTest.testOverload(RateLimitingTest.java:198) > at > org.apache.cassandra.transport.RateLimitingTest.shouldThrowOnOverloadSmallMessages(RateLimitingTest.java:111) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org