[
https://issues.apache.org/jira/browse/CASSANDRA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628068#comment-17628068
]
Brad Schoening edited comment on CASSANDRA-16640 at 11/3/22 2:17 AM:
---------------------------------------------------------------------
[~smiklosovic] so, it turns out to be a little awkward to split these back out,
as in error prone. The intent of this Jira was to improve unit test coverage
of the completions: {_}round out cqlsh completion test coverage{_}, so it seems
reasonable to add missing 'if exists' tests here. They were, after all, missing
from the completions tests and part of rounding them out. Also, adding unit
test often means fixing the upstream code along side the tests.
was (Author: bschoeni):
[~smiklosovic] so, it turns out to be a little awkward to split these back out,
as in error prone. The intent of this Jira was to improve unit test coverage
of the completions: {_}round out cqlsh completion test coverage{_}, so it seems
reasonable to add missing 'if exists' tests here. Also, fixing or adding unit
test often means fixing the upstream code together.
> Round out cqlsh completion test coverage
> ----------------------------------------
>
> Key: CASSANDRA-16640
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16640
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter, Test/unit
> Reporter: Adam Holmberg
> Assignee: Brad Schoening
> Priority: Low
> Fix For: 4.x
>
>
> There are some missing tests in cqlsh completion. Some highlighted
> [here|https://github.com/apache/cassandra/blob/10a1d65eb09a93aee32948b46b4f1a0fbc2defe0/pylib/cqlshlib/test/test_cqlsh_completion.py#L808-L824].
> There might be more needing coverage that are not enumerated.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
