[ https://issues.apache.org/jira/browse/CASSANDRA-18000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628885#comment-17628885 ]
Andres de la Peña edited comment on CASSANDRA-18000 at 11/4/22 10:53 AM: ------------------------------------------------------------------------- Great, thanks for the quick review. I've fixed the link for the 4.1 patch. [~e.dimitrova] this modifies 2-3 lines in the {{config-2_1.yml}} file. Those lines are out of the workflows section and don't require updating the patch files. Committing this can wait for CASSANDRA-17912 to ease conflict resolution. was (Author: adelapena): Great, thanks for the quick review. I've fixed the link for the 4.1 patch. [~e.dimitrova] this modifies 2-3 lines in the {{config-2_1.yml}} file. Those lines are of the workflows section and don't require updating the patch files. Committing this can wait for CASSANDRA-17912 to ease conflict management. > CircleCI: Skip checkstyle in the Ant-based repeated tests > --------------------------------------------------------- > > Key: CASSANDRA-18000 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18000 > Project: Cassandra > Issue Type: Task > Components: CI > Reporter: Andres de la Peña > Assignee: Andres de la Peña > Priority: Normal > > The CircleCI jobs for repeating Ant-based tests include the {{checkstyle}} > and {{checkstyle-test}} targets. Those targets are skipped for Java 11 but > not for Java 8. > Including those targets on every test iteration produces a significant > difference in the run times of repeated test jobs for j8 and j11: > * > [https://app.circleci.com/pipelines/github/adelapena/cassandra/2328/workflows/122d58b9-b454-4a99-8c46-f7777b7ef225/jobs/23225] > * > [https://app.circleci.com/pipelines/github/adelapena/cassandra/2328/workflows/50f33d9b-c7c6-4aa9-bac9-22ac78ad6b8c/jobs/23224] > We should use the {{no-checkstyle}} flag in the iterations done by those > jobs. That should significantly speed up the jobs and save resources. > > Thanks to [~bereng] , who detected the difference in the running times > between j8 and j11. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org