[ 
https://issues.apache.org/jira/browse/CASSANDRA-17964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630204#comment-17630204
 ] 

Berenguer Blasi commented on CASSANDRA-17964:
---------------------------------------------

So, PRs LGTM. Jenkins failures align to the per-commit CI so this LGTM Also. 
Circle failures we can use CASSANDRA-18000 as a reference imo despite there are 
50 executors there when we only have 25 in this ticket. So given jenkins runs 
are ok, dtests should be unaffected and circle runs here seem to be on a lower 
tier we should be ok there also.

I would also fix newer failing tests in dedicated tickets.

> Some tests are never executed due to naming violation - fix it and add 
> checkstyle where applicable
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17964
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17964
>             Project: Cassandra
>          Issue Type: Task
>          Components: Test/unit
>            Reporter: Ruslan Fomkin
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> [BatchTests|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/BatchTests.java]
>  doesn't follow naming convention to be run as unit tests and, thus, is never 
> run.
> The rule in build expects names as `*Test`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to