[
https://issues.apache.org/jira/browse/CASSANDRA-18024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630437#comment-17630437
]
Andres de la Peña commented on CASSANDRA-18024:
-----------------------------------------------
Thanks for the quick review. I have posted CI for the rest of the branches.
[~e.dimitrova] do you want to take a look? We should coordinate in which order
we merge to reduce rebase pains. This one is quite simple, I'd say.
{quote}wdyt about adding a job to configs that would fail with a message saying
'Caution: manually copying the file will skip auto multiplexing runs bla bla
bla? Please use generate.sh instead.'. Generate.sh could remove it. That would
protect us from the wall of green that didn't actually multiplex anything and
the other problems
{quote}
At the moment using those files is considered legitimate IMO, otherwise we
wouldn't have them. I think we shouldn't fail CI just to print a message that
the user might already be aware of. Not sure about how else we could print a
warning without resorting to adding a specific job and failing the entire
workflow.
Also, note that the automatic detection of modified test is not a guarantee
that all relevant tests have been selected or run, and we'll always need human
supervision to verify that everything is included and actually run. The
automatic detection is just a helper so we don't have to write the parameters,
but IMO both assignee a reviewers should always take a look at what has been
run.
Another question is whether we want to provide the default files with different
resource configs at all, or just make using the script mandatory. I think I
wouldn't be against removing them, and maybe provide only the default
{{config.yml}} that uses lowres for newcomers.
{quote}I can do that in another ticket if you're too far down the rabbit hole
with this one and don't want to redo the gazillion branches/files
{quote}
I'd definitively do/discuss that in a separate ticket.
> Circle repeat jobs are always triggered even if not necessary
> -------------------------------------------------------------
>
> Key: CASSANDRA-18024
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18024
> Project: Cassandra
> Issue Type: Bug
> Reporter: Berenguer Blasi
> Priority: Normal
>
> It seems that when pushing a PR, the auto multiplexing of new tests triggers
> all multiplexing jobs, even if there are no tests present for that job.
> That is wasteful as it means spinning up many nodes etc for nothing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
