[
https://issues.apache.org/jira/browse/CASSANDRA-18055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
maxwellguo updated CASSANDRA-18055:
-----------------------------------
Reviewers: Brandon Williams, Ekaterina Dimitrova (was: Brandon Williams)
> Nodetool Compact set the compaction type incorrectly
> ----------------------------------------------------
>
> Key: CASSANDRA-18055
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18055
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction, Tool/nodetool
> Reporter: maxwellguo
> Assignee: maxwellguo
> Priority: Low
> Fix For: 4.x
>
> Attachments: 20221116235846.jpg
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When using nodetool compactionstats to see what does the c*'s compactions are
> doing ,the output has got a column named "compaction type", but It seem that
> major compaction and minor compaction 's type are all name Compaction, after
> read the code I found that may be the the MAJOR_COMPACTION OperationType is
> not setted into AbstractCompactionTask
> at this method : CompactionStrategyManager -> getMaximalTasks .When we peform
> a major compact without any arguments we will got this execute path :
> {code:java}
> // Some comments here
> Compact.java : probe.forceKeyspaceCompaction(splitOutput, keyspace,
> tableNames);
> --->
> ColumnFamilyStore.java : cfStore.forceMajorCompaction(splitOutput);
> --->
> CompactionManager.java : submitMaximal(cfStore, gcBefore, splitOutput,
> OperationType.MAJOR_COMPACTION);
> {code}
> Unfortunately OperationType.MAJOR_COMPACTION is not rightly setted.
> see the picture on the right I perform a major compact , and on the left the
> compactionstats show the type is only Compaction ;
> I think it is import for us to know wether the task is a major or a minor .
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
