[ 
https://issues.apache.org/jira/browse/CASSANDRA-17848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643139#comment-17643139
 ] 

Berenguer Blasi edited comment on CASSANDRA-17848 at 12/5/22 7:21 AM:
----------------------------------------------------------------------

Hi [~yifanc],

thanks for resubmitting it. Iirc you only need one approval for the pre-commit 
workflow. It's mostly green but for a few in 4.1 and trunk which really sound 
like flakies to me. I would still open a ticket for the {{test_cleanup}} one 
and any other one you might consider worth it. But otherwise LGTM +1.


was (Author: bereng):
Hi [~yifanc],

thanks for resubmitting it. Iirc you only need one approval for the pre-commit 
workflow. It's mostly green but for a few in 4.1 and trunk which really sound 
like flakies to me. I would still open a ticket for the {{test_cleanup}} one 
and other one you might consider worth it. But otherwise LGTM +1.

> Fix incorrect resource name in LIST PERMISSION output
> -----------------------------------------------------
>
>                 Key: CASSANDRA-17848
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17848
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL/Interpreter
>            Reporter: Yifan Cai
>            Assignee: Yifan Cai
>            Priority: Normal
>             Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When producing the resource name, it seems to assume that the content in the 
> `[]` is the function's input type, where it could also be part of the 
> function name, as long as it is quoted. Here is an example to reproduce. In 
> cqlsh,
> {code:java}
> > CREATE FUNCTION 
> > test."admin_created_udf[org.apache.cassandra.db.marshal.LongType]"(input 
> > int) RETURNS NULL ON NULL INPUT RETURNS int LANGUAGE java AS 'return 42;';
> > LIST EXECUTE OF user;
>  role  | username | resource                                | permission
> -------+----------+-----------------------------------------+------------
>  user  |    user  | <function test.admin_created_udf(long)> |    EXECUTE
> (1 rows)
> {code}
> The input should be "int", but in the output, it says "long". 
> If the content enclosed by "[]" is not a valid class, the LIST PERMISSION 
> request always fails for the user with "ConfigurationException: Unable to 
> find abstract-type class".
> The bug is discovered by Piotr Sarna.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to