[
https://issues.apache.org/jira/browse/CASSANDRA-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646319#comment-17646319
]
Ekaterina Dimitrova commented on CASSANDRA-17178:
-------------------------------------------------
+1 on the PR, thank you.
{quote}org.apache.cassandra.simulator.test.ShortPaxosSimulationTest was flakey
in J8 but not j11
{quote}
As long as it is flaky also without the patch and we follow up by opening a
ticket for the community to look at the flaky test, all good :)
Please get rid of the hunk messages pre-commit as I mentioned in Slack.
Regenerating the patches without any actual changes to them will get rid of
that list of ugly warnings when people run .generate.sh with the flags. Just
try to apply them to the files to see they do not change anything after the
regeneration. Thanks
Easy recipe(copy-paste) to do that:
{code:java}
#. apply old patches (with hunk messages)
patch -o config-2_1.yml.MIDRES config-2_1.yml config-2_1.yml.mid_res.patch
patch -o config-2_1.yml.HIGHRES config-2_1.yml config-2_1.yml.high_res.patch
#. generate new patches
diff -u config-2_1.yml config-2_1.yml.HIGHRES > config-2_1.yml.high_res.patch
diff -u config-2_1.yml config-2_1.yml.MIDRES > config-2_1.yml.mid_res.patch
#. verify that the new patches generate the same files and cleanup
./generate.sh -a
{code}
> CEP-10: Simulator Java11 Support
> --------------------------------
>
> Key: CASSANDRA-17178
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17178
> Project: Cassandra
> Issue Type: Task
> Components: Test/fuzz
> Reporter: Benedict Elliott Smith
> Assignee: David Capwell
> Priority: Normal
> Fix For: NA
>
>
> Java11 introduces new protection domains for package private methods, so that
> classes loaded with different class loaders may not access each others’
> package private methods, regardless of the package they are declared within.
> There are differences within the JDK also, and there may be byte weaving
> targets that need updating (ThreadLocalRandom was one that has been handled)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
