[
https://issues.apache.org/jira/browse/CASSANDRA-14013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649434#comment-17649434
]
Paulo Motta edited comment on CASSANDRA-14013 at 12/20/22 7:16 PM:
-------------------------------------------------------------------
{quote} In that case, could you add a test in SSTableLoaderTest as it was, that
it is loading it just fine without uuid as well?
{quote}
done
[here|https://github.com/pauloricardomg/cassandra/commit/9cc0f63171c60e927af18eb3256eb63a29916a43].
During a [CI
run|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2114/testReport/]
of the trunk patch, I realized the original regex was only accepting ".db"
sstable files, so it was failing to correctly parse other extensions (such as
.txt or .crc32). So I updated the regex to accept any extension on [this
commit|https://github.com/pauloricardomg/cassandra/commit/345222a3e2504a84ef91eb25e35ae23762c34178].
We could make the regex more prescriptive with only supported extensions, but
I don't think this is needed for now.
I prepared 4.0/4.1 patches with the less disruptive fix, and the trunk patch
with the improved regex-based fix:
|branch||CI||
|[CASSANDRA-14013-4.0|https://github.com/pauloricardomg/cassandra/tree/CASSANDRA-14013-4.0]|[#2115|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2115/]
(finished)|
|[CASSANDRA-14013-4.1|https://github.com/pauloricardomg/cassandra/tree/CASSANDRA-14013-4.1]|[#2121|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2121/]
(finished)|
|[CASSANDRA-14013-trunk|https://github.com/pauloricardomg/cassandra/tree/CASSANDRA-14013-trunk]|[#2125|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2125/]
(running)|
(will update state when CI is finished)
Are you ok with the improved regex fix to trunk [~blerer], while having the
simpler fix on 4.x to reduce risk on released versions?
was (Author: paulo):
{quote} In that case, could you add a test in SSTableLoaderTest as it was, that
it is loading it just fine without uuid as well?
{quote}
done
[here|https://github.com/pauloricardomg/cassandra/commit/9cc0f63171c60e927af18eb3256eb63a29916a43].
During a [CI
run|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2114/testReport/]
of the trunk patch, I realized the original regex was only accepting ".db"
sstable files, so it was failing to correctly parse other extensions (such as
.txt or .crc32). So I updated the regex to accept any extension on [this
commit|https://github.com/pauloricardomg/cassandra/commit/345222a3e2504a84ef91eb25e35ae23762c34178].
We could make the regex more prescriptive with only supported extensions, but
I don't think this is needed for now.
I prepared 4.0/4.1 patches with the less disruptive fix, and the trunk patch
with the improved regex-based fix:
|branch||CI||
|[CASSANDRA-14013-4.0|https://github.com/pauloricardomg/cassandra/tree/CASSANDRA-14013-4.0]|[#2115|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2115/]
(finished)|
|[CASSANDRA-14013-4.1|https://github.com/pauloricardomg/cassandra/tree/CASSANDRA-14013-4.1]|[#2121|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2122/]
(running)|
|[CASSANDRA-14013-trunk|https://github.com/pauloricardomg/cassandra/tree/CASSANDRA-14013-trunk]|[#2122|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2122/]
(running)|
(will update state when CI is finished)
Are you ok with the improved regex fix to trunk [~blerer], while having the
simpler fix on 4.x to reduce risk on released versions?
> Data loss in snapshots keyspace after service restart
> -----------------------------------------------------
>
> Key: CASSANDRA-14013
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14013
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Core, Local/Snapshots
> Reporter: Gregor Uhlenheuer
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.0.x, 4.1.x, 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I am posting this bug in hope to discover the stupid mistake I am doing
> because I can't imagine a reasonable answer for the behavior I see right now
> :-)
> In short words, I do observe data loss in a keyspace called *snapshots* after
> restarting the Cassandra service. Say I do have 1000 records in a table
> called *snapshots.test_idx* then after restart the table has less entries or
> is even empty.
> My kind of "mysterious" observation is that it happens only in a keyspace
> called *snapshots*...
> h3. Steps to reproduce
> These steps to reproduce show the described behavior in "most" attempts (not
> every single time though).
> {code}
> # create keyspace
> CREATE KEYSPACE snapshots WITH replication = {'class': 'SimpleStrategy',
> 'replication_factor': 1};
> # create table
> CREATE TABLE snapshots.test_idx (key text, seqno bigint, primary key(key));
> # insert some test data
> INSERT INTO snapshots.test_idx (key,seqno) values ('key1', 1);
> ...
> INSERT INTO snapshots.test_idx (key,seqno) values ('key1000', 1000);
> # count entries
> SELECT count(*) FROM snapshots.test_idx;
> 1000
> # restart service
> kill <cassandra-pid>
> cassandra -f
> # count entries
> SELECT count(*) FROM snapshots.test_idx;
> 0
> {code}
> I hope someone can point me to the obvious mistake I am doing :-)
> This happened to me using both Cassandra 3.9 and 3.11.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
