[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651675#comment-17651675 ]
Mike Adamson commented on CASSANDRA-18058: ------------------------------------------ [~maedhroz] Thanks for your review. I am away now for 2 weeks so will get on to this when I return. With regard to the deprecating IndexingQuerySupport. I have given this some serious thought but have the following reservations. IndexingQuerySupport uses a network session for queries in order to test limit and paging. This impacts performance and would make the large number of indexing type tests slower. I'm not sure of the impact of this but it is worth bearing in mind. This test framework has also highlighted a number of bugs that haven't shown up elsewhere. What might make sense would be to enhance IndexingTypeSupport to include any indexing variations (pk, ck, static), operations (ttl, deletions) and query variants that it doesn't already cover and restrict IndexingQuerySupport (probably renamed) to limit and paging. I would also be inclined to randomise this as well. I am very happy to do this but would prefer to leave it until we have the on-disk support added. This would give us a better idea of scope. > In-memory index and query path > ------------------------------ > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI > Reporter: Mike Adamson > Assignee: Mike Adamson > Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org