[ https://issues.apache.org/jira/browse/CASSANDRA-18116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jordan West updated CASSANDRA-18116: ------------------------------------ Test and Documentation Plan: Existing tests (exploring if I can add one more to produce this case and show how reads trigger a load of the denylist) Status: Patch Available (was: Open) [https://github.com/jrwest/cassandra/tree/jwest/18116-4.1] Tests: [j8|https://app.circleci.com/pipelines/github/jrwest/cassandra/128/workflows/474f1780-f3e5-4c61-8c26-c0ddf3408017] [j11|https://app.circleci.com/pipelines/github/jrwest/cassandra/128/workflows/2fe470f3-6743-42e6-b4ab-5d8399a9e814] > Denylist can load perpetually and too frequently if it fails persistently > -------------------------------------------------------------------------- > > Key: CASSANDRA-18116 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18116 > Project: Cassandra > Issue Type: Bug > Components: Feature/Rate Limiting > Reporter: Jordan West > Assignee: Jordan West > Priority: Normal > Fix For: 4.0.x, 4.1.x > > > When the denylist fails its initial load it can [return a value of > null|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/PartitionDenylist.java#L453] > for a key in the cache. The [BoundedLoadingCache > implementation|https://github.com/ben-manes/caffeine/blob/master/caffeine/src/main/java/com/github/benmanes/caffeine/cache/BoundedLocalCache.java#L2591-L2615] > that is used treats null as missing and will end up trying to load the key > on reads. Besides the performance impact this can also lead to significant > log spam leading to disk or CPU usage issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org