[ 
https://issues.apache.org/jira/browse/CASSANDRA-18022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654195#comment-17654195
 ] 

David Capwell commented on CASSANDRA-18022:
-------------------------------------------

did first pass; feedback

* I think your change to MetricRecording is not correct... if we read multiple 
partitions we attribute rows/tombstones to that single partition... This case 
can happen with PartitionRangeReadCommand, so would be good to add tests 
showing correct behavior
* No tests are included, can you provide some tests?

> Extend profileload to track by additional metrics
> -------------------------------------------------
>
>                 Key: CASSANDRA-18022
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18022
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tool/nodetool
>            Reporter: Jordan West
>            Assignee: Jordan West
>            Priority: Normal
>
> Add option to toppartitions to track by:
>  * Row Count
>  * Tombstone Count
>  * SSTable Count
>  * Latency



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to