[
https://issues.apache.org/jira/browse/CASSANDRA-18152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676580#comment-17676580
]
Stefan Miklosovic edited comment on CASSANDRA-18152 at 1/13/23 11:04 AM:
-------------------------------------------------------------------------
PR: https://github.com/apache/cassandra/pull/2095
builld:
https://app.circleci.com/pipelines/github/instaclustr/cassandra?branch=CASSANDRA-18152
was (Author: smiklosovic):
PR: https://github.com/apache/cassandra/pull/2095
https://app.circleci.com/pipelines/github/instaclustr/cassandra?branch=CASSANDRA-18152
> mockito-inline causes tests to fail beacause
> o.a.c.distributed.mock.nodetool.InternalNodeProbe spies on StorageServiceMBean
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18152
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18152
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While working on CASSANDRA-14361, when we included mockito-inline into the
> build to test the new functionality, unrelated tests in CI started to fail.
> (1)
> This is happening because mockito, together with stuff which enables static
> mocking, just does not play together with our way of doing things in dtest
> framework.
> The workaround is consisting of removing Mockito from InternalNodeProbe, it
> tries to spy on StorageService to not send any notifications back. This might
> be workarounded so we do not need Mockito hence tests are fixed and mocking
> of static methods is possible without any other tests failing.
> (1)
> https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2168/#showFailuresLink
> see also: [https://github.com/mockito/mockito/issues/2203]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
