[
https://issues.apache.org/jira/browse/CASSANDRA-16325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678015#comment-17678015
]
Paulo Motta commented on CASSANDRA-16325:
-----------------------------------------
The new approach looks good to me. Right now,
{{testMetricsUpdateIncrementallyWithRepairAndStreamingBetweenNodes}} and
{{testMetricsUpdateIncrementallyWithRebuildAndStreamingBetweenNodes}} are only
testing the uncompressed/partial stream path. I think we should extend these
tests to also test the metrics are working correctly for compressed and
{{stream_entire_sstables=true}}
I don't expect these more frequent streamed bytes counter updates to have any
noticeable impact on streaming performance, but if processing of downstream
streaming listeners turn out to be a bottleneck I think we should send the
notifications on a separate thread versus adding special logic to batch metric
updates to not make this overly complex.
> Update streaming metrics incrementally
> --------------------------------------
>
> Key: CASSANDRA-16325
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16325
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Metrics
> Reporter: Paulo Motta
> Assignee: Isaac Reath
> Priority: Normal
> Labels: lhf
> Fix For: 4.2
>
> Time Spent: 10h 10m
> Remaining Estimate: 0h
>
> Currently the inbound and outbound streamed bytes metrics are incremented
> after each file is streamed, what doesn't represent the current number of
> bytes streamed since it can take a long time for a large file to be streamed.
> We should update the metric incrementally as data is streamed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
