[
https://issues.apache.org/jira/browse/CASSANDRA-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086638#comment-13086638
]
Hudson commented on CASSANDRA-3046:
-----------------------------------
Integrated in Cassandra #1033 (See
[https://builds.apache.org/job/Cassandra/1033/])
update enum comparison to use ==
patch by dbrosius; reviewed by jbellis for CASSANDRA-3046
jbellis :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1158932
Files :
* /cassandra/trunk/src/java/org/apache/cassandra/db/marshal/FloatType.java
* /cassandra/trunk/src/java/org/apache/cassandra/cache/AutoSavingCache.java
* /cassandra/trunk/src/java/org/apache/cassandra/db/index/SecondaryIndex.java
* /cassandra/trunk/src/java/org/apache/cassandra/thrift/ThriftValidation.java
* /cassandra/trunk/src/java/org/apache/cassandra/config/ColumnDefinition.java
* /cassandra/trunk/src/java/org/apache/cassandra/cql/WhereClause.java
* /cassandra/trunk/src/java/org/apache/cassandra/service/StorageProxy.java
* /cassandra/trunk/src/java/org/apache/cassandra/cql/Relation.java
* /cassandra/trunk/src/java/org/apache/cassandra/cql/QueryProcessor.java
* /cassandra/trunk/src/java/org/apache/cassandra/db/index/keys/KeysSearcher.java
> [patch] No need to use .equals on enums, just opens up chance of NPE
> --------------------------------------------------------------------
>
> Key: CASSANDRA-3046
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3046
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Dave Brosius
> Assignee: Dave Brosius
> Priority: Trivial
> Fix For: 1.0
>
> Attachments: enum_equality.diff
>
>
> pretty trivial patch that change enum1.equals(enum2) into enum1 == enum2, as
> .equals isn't needed, and just opens up the possibility of NPEs where ==
> handles them correctly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
