[
https://issues.apache.org/jira/browse/CASSANDRA-18153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680524#comment-17680524
]
Stefan Miklosovic commented on CASSANDRA-18153:
-----------------------------------------------
Hi [~abonacin]
I think I fixed what I wrote yesterday here:
[https://github.com/apache/cassandra/pull/2113/files]
Now test always returns this:
{code:java}
/tmp/dtests8231883753452384466/node1/data0/system/local-7ad54392bcdd35a684174e047860b377/nb-2-big
-> 00000000-0000-4000-8000-000000000001
/tmp/dtests8231883753452384466/node1/data0/system/local-7ad54392bcdd35a684174e047860b377/nb-1-big
-> 00000000-0000-4000-8000-000000000001
local host id -> 00000000-0000-4000-8000-000000000001
{code}
What do you think?
[~jlewandowski] I think that there is slight advantage of using it like
[~abonacin] suggested because if we did SystemKeyspace.getLocalHostId only, we
would need to go to disk / execute query every single time instead of just
reading it from memory, basically.
> Memtable being flushed without hostId in version "me" and newer during
> CommitLogReplay
> --------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18153
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18153
> Project: Cassandra
> Issue Type: Bug
> Components: Local/SSTable
> Reporter: Adriano Bonacin
> Assignee: Adriano Bonacin
> Priority: Normal
> Time Spent: 50m
> Remaining Estimate: 0h
>
> On ticket CASSANDRA-16619 some files were changed to allow Cassandra to store
> HostID in the new "me" SSTable version.
> But SSTables flushed during CommitLogReplay miss this HostID info.
>
> In the next Cassandra startup, if these SSTables were still present,
> system.log will show:
> {{WARN Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored}}
> {{WARN }}{{{}Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored{}}}{{{}{}}}{{ }}
>
> And debug.log will show a list of SSTables, witch can include "md" and "me"
> version (before upgradesstables):
>
> {{Ignored commitLogIntervals from the following sstables:
> [/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/me-3-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-1-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-2-big-Data.db]}}
>
> https://issues.apache.org/jira/browse/CASSANDRA-16619
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
