[ 
https://issues.apache.org/jira/browse/CASSANDRA-18155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681188#comment-17681188
 ] 

Berenguer Blasi commented on CASSANDRA-18155:
---------------------------------------------

I see:
 * The schema reset test is CASSANDRA-18151
 * invalidSingleCredetial shouldn't be there. That has been wrongly identified 
by the multiplexer as a new or modified test. Do you have an explanation or is 
it a bug we need to fix bc of the waste of money? Either way the multiplexer 
did run the test you added so we're good.
 * reloadtrie is CASSANDRA-18144
 * CS one is CASSANDRA-17674

I have 2 worry points
 * This CI run is not the std one. I'll +1 if you assure me they both are the 
same as I can't visually match them
 * I'm worried about the wrongly identified repeat tests, we should open a 
ticket or find out what happened.

LGTM +1 conditional to the 2 points above

> Coordinator level metrics for read response and mutation row and column counts
> ------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-18155
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18155
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Observability/Metrics
>            Reporter: Caleb Rackliffe
>            Assignee: Caleb Rackliffe
>            Priority: Normal
>             Fix For: 4.x
>
>          Time Spent: 4.5h
>  Remaining Estimate: 0h
>
> We propose creating a new metric group, {{ClientRequestSize}}, that will 
> house 4 new coordinator-level metrics:
> 1.) ColumnsRead - the total number of columns returned from the database to 
> clients
> 2.) RowsRead - the total number of rows returned from the database to clients
> 3.) ColumnsWritten - the total number of columns written to the database by 
> clients
> 4.) RowsWritten - the total number of rows written to the database by clients



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to