[
https://issues.apache.org/jira/browse/CASSANDRA-18204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681452#comment-17681452
]
Michael Semb Wever edited comment on CASSANDRA-18204 at 1/27/23 7:55 PM:
-------------------------------------------------------------------------
bq. release artifact must include the submodule and must be able to build
without issue
nit: release artifact must include the submodule's source and must be able to
build without issue
as source release artifacts do not contain the .git subfolder (or any git info)
bq. build.xml must be updated to release the submodule jar
is this a requirement? so long as the submodule jar in the binary release is
exactly rebuildable by both SHA and the matching source release, then we are
good.
was (Author: michaelsembwever):
bq. release artifact must include the submodule and must be able to build
without issue
nit: release artifact must include the submodule's source and must be able to
build without issue
as source release artifacts do not contain the .git subfolder (or any git info)
> CEP-15: (C*) Add git submodule for Accord
> -----------------------------------------
>
> Key: CASSANDRA-18204
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18204
> Project: Cassandra
> Issue Type: Task
> Components: Accord
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Fix For: 4.x
>
>
> As talked about in dev@ thread "Intra-project dependencies”, we talked about
> adding git submodules but before doing this had to work out a few issues
> first; this ticket is to track this work.
> Goals
> * when checking out an older commit, or pulling in newer commits, the
> submodule should also be updated automatically
> * release artifact must include the submodule and must be able to build
> without issue
> * build.xml must be updated to build the submodule
> * build.xml must be updated to release the submodule jar
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
