[
https://issues.apache.org/jira/browse/CASSANDRA-14227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683716#comment-17683716
]
Berenguer Blasi commented on CASSANDRA-14227:
---------------------------------------------
Putting this back into review with the new Uint approach. I have done a final
round of perf testing:
* Perf testing revolved around 10M rows and runs with random/fixed TTL for
period of 2m, 5m and 10m. The exception being the much longer latency test.
* Longer tests tend to give less noisy results. 14227 vs trunk may randomly
appear one slightly better than the other which I attribute to env noise and
lack of dedicated perf testing HW.
* Latency seems to be aligned as per comment above
* Disk size, flushes etc seem to be aligned. Here is some table stats where
sometimes 14227 is slightly better and sometimes the other way around
!unnamed.png!
The PR has several commits to make it easier to review. Some refactoring of an
earlier commit might be found in a later one but nothing too big and quite
straightforward. I have left a bunch of 14227 TODO comments to bring the
attention of the reviewer just for feedback. CI can be found in the PR.
The only thing to note is the addition of the NONE policy where it's later
removed. That is the only bit it can't be easily collapsed, apologies in
advance.
> Extend maximum expiration date
> ------------------------------
>
> Key: CASSANDRA-14227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14227
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
> Reporter: Paulo Motta (Deprecated)
> Assignee: Berenguer Blasi
> Priority: Urgent
> Fix For: 4.x
>
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png,
> screenshot-4.png, unnamed-1.png, unnamed.png
>
>
> The maximum expiration timestamp that can be represented by the storage
> engine is
> 2038-01-19T03:14:06+00:00 due to the encoding of {{localExpirationTime}} as
> an int32.
> On CASSANDRA-14092 we added an overflow policy which rejects requests with
> expiration above the maximum date as a temporary measure, but we should
> remove this limitation by updating the storage engine to support at least the
> maximum allowed TTL of 20 years.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
