[
https://issues.apache.org/jira/browse/CASSANDRA-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685993#comment-17685993
]
Derek Chen-Becker commented on CASSANDRA-17979:
-----------------------------------------------
I've replaced both assertions with a new method to validate delivery and I've
renamed everything to make it clear that they also test delivery. CircleCI is
running unit tests now. I'm going to disagree with the idea that every unit
test should be an integration test (message delivery is tested in other test
classes), but in the interest of fixing a flaky test we can hopefully merge
this soon.
> Fix flaky
> test:org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades
> ---------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17979
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17979
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Internode
> Reporter: Brandon Williams
> Assignee: Derek Chen-Becker
> Priority: Normal
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1339/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_cdc/
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1336/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_compression/
> https://app.circleci.com/pipelines/github/instaclustr/cassandra/1466/workflows/ffb52616-92d7-4089-a0c9-a9ebf28333c0/jobs/6296/tests
> {noformat}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:384)
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:243)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
