[ https://issues.apache.org/jira/browse/CASSANDRA-18252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687490#comment-17687490 ]
Ekaterina Dimitrova edited comment on CASSANDRA-18252 at 2/11/23 9:09 PM: -------------------------------------------------------------------------- Issue fixed, all tests pass now [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2296/workflows/c7a2642a-4674-4f5b-83c8-c5c0e1a94476] Also added CHANGES.txt and NEWS.txt entry and preliminary docs change to prevent people from confusion. I started sanity check testing with 4.1 [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2297/workflows/52a00c15-fa32-41ab-ab66-d61e2b8e7179] to verify the changes in the dtest repo did not break anything for previous branches Going to check the results later. Also, pre-commit I will test again this patch applied on top of CASSANDRA-18179 on trunk with JDK 17 that _ant build_ completes successfully as expected. Log to be posted here Before I forget, I will also add a note on CASSANDRA-17281 that we did not touch here anything around _enable_user_defined_functions_threads_ and _allow_insecure_udfs as I suspect_ those will be figured out there. _enable_user_defined_functions_threads_ is not even presented in _cassandra.yaml_ was (Author: e.dimitrova): Issue fixed, all tests pass now [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2296/workflows/c7a2642a-4674-4f5b-83c8-c5c0e1a94476] Also added CHANGES.txt and NEWS.txt entry and preliminary docs change to prevent people from confusion. I started sanity check testing with 4.1 [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2297/workflows/52a00c15-fa32-41ab-ab66-d61e2b8e7179] to verify the changes in the dtest repo did not break anything for previous branches Going to check the results later. Also, pre-commit I will test again this patch applied on top of CASSANDRA-18179 on trunk with JDK 17 that _ant build_ completes successfully as expected. Log to be posted here > Remove Scripted UDFs from trunk to enable easier JDK17 testing on current > trunk > ------------------------------------------------------------------------------- > > Key: CASSANDRA-18252 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18252 > Project: Cassandra > Issue Type: Task > Components: Feature/UDF > Reporter: Ekaterina Dimitrova > Assignee: Ekaterina Dimitrova > Priority: Normal > Fix For: 5.x > > > CASSANDRA-17281 was created to do the work around removing Scripted UDFs > Seems like adding hooks with the current Sandbox might be non-trivial, > considering that it was the reason for removing the hooks for other scripted > languages. > Also, Security Manager is deprecated already in Java 17, the current sandbox > had also some performance implications. With all that said, this ticket is > meant to blindly remove the scripted UDFs and any related tests and > CASSANDRA-17281 will be used for any UDF refactoring and addition of scripted > UDFs hooks. This will help us to speed up the incremental addition of JDK17 > builds and enable people to test directly on trunk instead of having their > own modified branches. Feature branch was considered but considering all > moving parts that we have to maintain a few different branches in different > repos and states it is too time-consuming to maintain. > Supportive ML thread where I will also post the result of this ticket for > final confirmation: > [https://lists.apache.org/thread/c39yrbdszgz9s34vr17wpjdhv6h2oo61] > *WARNING: The API for UDFs might change as part of CASSANDRA-17281 where > hooks will be introduced for JavaScript UDFs and some additional refactoring > is going to happen. This ticket primary goal is to clean the internals and > enable people to easily test with JDK17* -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org