[
https://issues.apache.org/jira/browse/CASSANDRA-18049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687493#comment-17687493
]
Ekaterina Dimitrova edited comment on CASSANDRA-18049 at 2/11/23 10:13 PM:
---------------------------------------------------------------------------
So I just took a look at your CI run and it fails, the patch will not be only
bumping the versions unfortunately.
I see a few things here:
- I will get back to my branch on Monday and see some of the other changes I
was looking into. I remember I had to add some exports when we start the tools
at least (if I am not mistaken they actually turned to be more than what was in
the article to make it work)
- I suggest first we clean here 11 and then I can also test 17. I had some
issues around chronicle in tests lately. But let's clean the branches and
retest, you also added the very last versions so things might have changed.
- we need to revise the changelog whether there were any changes between
versions that might affect us
- we need to revise
[that|https://chronicle.software/chronicle-support-java-17/] article around the
exports etc (where they recommend adding them also for 11) whether everything
is still the same with the newest versions
was (Author: e.dimitrova):
So I just took a look at your CI run and it fails, the patch will not be only
bumping the versions unfortunately.
I see a few things here:
- I will get back to my branch on Monday and see some of the other changes I
was looking into. I remember I had to add some exports when we start the tools
at least (if I am not mistaken they actually turned to be more than what was in
the article to make it work)
- I suggest first we clean here 11 and then I can also test 17. I had some
issues around chronicle in tests lately. But let's clean the branches and
retest, you also added the very last versions so things might have changed.
- we need to revise the changelog whether there were any changes between
versions that might affect us
- we need to revise that article around the exports etc (where they recommend
adding them also for 11) whether everything is still the same with the newest
versions
> Update Chronicle Queue
> ----------------------
>
> Key: CASSANDRA-18049
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18049
> Project: Cassandra
> Issue Type: Task
> Reporter: Ekaterina Dimitrova
> Assignee: Michael Semb Wever
> Priority: Normal
> Fix For: 4.x
>
>
> According to [this|https://chronicle.software/chronicle-support-java-17]
> article:
> {code:java}
> Starting from chronicle-bom-2.22ea26, all new releases can be run under Java
> 17 when run on the class path (but not yet under the module path).{code}
> This BOM is newer than what we currently have in both 4.1 and trunk. 4.1
> points in comments to
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/1.16.23] which
> I believe was just forgotten to be updated/removed. The versions we see
> correspond to this BOM
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/2.20.226]
> It is still older than chronicle-bom-2.22ea26 so we need to upgrade. I
> suggest we also add a comment again which BOM is considered, this makes
> things easier.
> Further to running CI, review of the CHANGE logs needs to happen to ensure we
> do not miss anything that can impact us and it is not caught by our tests.
> For testing with JDK17, please, contact [~e.dimitrova] for latest branch and
> CI config (at this point feature branch in the cassandra repo does not exist)
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
