[ 
https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689372#comment-17689372
 ] 

Ekaterina Dimitrova commented on CASSANDRA-18106:
-------------------------------------------------

{quote}If this patch doesn't find the supported versions from JdkProperties it 
will default to 11, so I think it should be safe to push first in that regard.
{quote}
Considering this is in a check that we have Cassandra version post 4.2, I 
agree. 
{quote}to push first in that regard.
{quote}
JdkProperties is already in trunk and it uses some hack to workaround the need 
of CASSANDRA_USE_JDK11 in CI, if I didn't misunderstand anything.

We need to be careful that we do not change anything for DSE or other products 
using CCM. The explicit approach with Cassandra version sounds reasonable to me 
in that regard

> Update CCM for JDK17 and revise current JDK detection strategy
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-18106
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18106
>             Project: Cassandra
>          Issue Type: Task
>          Components: CI
>            Reporter: Ekaterina Dimitrova
>            Assignee: Brandon Williams
>            Priority: Normal
>             Fix For: 4.x
>
>
> As part of CASSANDRA-16895 initial POC an initial version of CCM patch was 
> created. This needs to be revisited and reviewed
> Recently we closed CASSANDRA-18039 which brought questions, probably we need 
> to revise how we detect JDK versions in CCM and whether it is correct. To the 
> best of my knowledge there are certain tests in the repo around that and they 
> pass so my guess is we need to revise just the strategy and maybe document it 
> explicitly or consider if we want any changes to be applied. Also, we need to 
> be careful with breaking changes. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to