[
https://issues.apache.org/jira/browse/CASSANDRA-18204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689388#comment-17689388
]
David Capwell commented on CASSANDRA-18204:
-------------------------------------------
This is what I see as the source difference now
{code}
$ diff accord-source.txt original-source.txt | egrep -v
'.*\.java$|.*\.sh$|dev-support|\/$|CROSS-CUTTING-CONTRIBUTING.md'
5,69d4
75,80d9
707d635
713,1024d640
< apache-cassandra-4.2-SNAPSHOT-src/accord-source.txt
< apache-cassandra-4.2-SNAPSHOT-src/accord/.circleci/config.yml
< apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/7.6/checksums/checksums.lock
<
apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/7.6/checksums/md5-checksums.bin
<
apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/7.6/checksums/sha1-checksums.bin
<
apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/7.6/checksums/sha256-checksums.bin
<
apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/7.6/checksums/sha512-checksums.bin
<
apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/7.6/dependencies-accessors/dependencies-accessors.lock
<
apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/7.6/dependencies-accessors/gc.properties
<
apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/7.6/executionHistory/executionHistory.bin
<
apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/7.6/executionHistory/executionHistory.lock
<
apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/7.6/fileChanges/last-build.bin
< apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/7.6/fileHashes/fileHashes.bin
<
apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/7.6/fileHashes/fileHashes.lock
<
apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/7.6/fileHashes/resourceHashesCache.bin
< apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/7.6/gc.properties
<
apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/buildOutputCleanup/buildOutputCleanup.lock
<
apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/buildOutputCleanup/cache.properties
<
apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/buildOutputCleanup/outputFiles.bin
< apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/file-system.probe
< apache-cassandra-4.2-SNAPSHOT-src/accord/.gradle/vcs-1/gc.properties
< apache-cassandra-4.2-SNAPSHOT-src/accord/accord-core/build.gradle
<
apache-cassandra-4.2-SNAPSHOT-src/accord/accord-core/src/test/resources/burn-logback-trace-rolling.xml
<
apache-cassandra-4.2-SNAPSHOT-src/accord/accord-core/src/test/resources/burn-logback-trace.xml
<
apache-cassandra-4.2-SNAPSHOT-src/accord/accord-core/src/test/resources/burn-logback.xml
< apache-cassandra-4.2-SNAPSHOT-src/accord/accord-maelstrom/build.gradle
< apache-cassandra-4.2-SNAPSHOT-src/accord/build.gradle
<
apache-cassandra-4.2-SNAPSHOT-src/accord/buildSrc/.gradle/7.6/executionHistory/executionHistory.bin
<
apache-cassandra-4.2-SNAPSHOT-src/accord/buildSrc/.gradle/7.6/executionHistory/executionHistory.lock
<
apache-cassandra-4.2-SNAPSHOT-src/accord/buildSrc/.gradle/buildOutputCleanup/buildOutputCleanup.lock
<
apache-cassandra-4.2-SNAPSHOT-src/accord/buildSrc/.gradle/buildOutputCleanup/cache.properties
<
apache-cassandra-4.2-SNAPSHOT-src/accord/buildSrc/.gradle/buildOutputCleanup/outputFiles.bin
< apache-cassandra-4.2-SNAPSHOT-src/accord/buildSrc/.gradle/file-system.probe
<
apache-cassandra-4.2-SNAPSHOT-src/accord/buildSrc/.gradle/noVersion/buildSrc.lock
< apache-cassandra-4.2-SNAPSHOT-src/accord/buildSrc/build.gradle
<
apache-cassandra-4.2-SNAPSHOT-src/accord/buildSrc/src/main/groovy/accord.java-conventions.gradle
< apache-cassandra-4.2-SNAPSHOT-src/accord/gradle.properties
< apache-cassandra-4.2-SNAPSHOT-src/accord/gradle/wrapper/gradle-wrapper.jar
<
apache-cassandra-4.2-SNAPSHOT-src/accord/gradle/wrapper/gradle-wrapper.properties
< apache-cassandra-4.2-SNAPSHOT-src/accord/gradlew
< apache-cassandra-4.2-SNAPSHOT-src/accord/gradlew.bat
< apache-cassandra-4.2-SNAPSHOT-src/accord/settings.gradle
1072,1080d687
{code}
[~mck] I think the .gradle jar should also be excluded, what do you think?
accord/gradle/wrapper/gradle-wrapper.jar is committed, so will be needed in
source, but I think that's it?
> CEP-15: (C*) Add git submodule for Accord
> -----------------------------------------
>
> Key: CASSANDRA-18204
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18204
> Project: Cassandra
> Issue Type: Task
> Components: Accord
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Fix For: 4.x
>
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> As talked about in dev@ thread "Intra-project dependencies”, we talked about
> adding git submodules but before doing this had to work out a few issues
> first; this ticket is to track this work.
> Goals
> * when checking out an older commit, or pulling in newer commits, the
> submodule should also be updated automatically
> * release artifact must include the submodule and must be able to build
> without issue
> * build.xml must be updated to build the submodule
> * build.xml must be updated to release the submodule jar
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
