[
https://issues.apache.org/jira/browse/CASSANDRA-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689824#comment-17689824
]
Ekaterina Dimitrova edited comment on CASSANDRA-18179 at 2/16/23 4:19 PM:
--------------------------------------------------------------------------
{quote} I've created CASSANDRA-18267)
{quote}
Thanks
{quote}This patch ninja-fixes JdkProperties and fixes the above targets
{quote}
I can confirm that it fixed the issue I was seeing in IDEA yesterday.
eclipse-warnings and checkstyle - I can neither deny, nor confirm they were
broken/fixed/working from the log. When I run them with any jdk they always
finish with "BUILD SUCCESSFUL"
Is there a way to add anything to the logs?
I think I mentioned it before that there is comment in build.xml that
eclipse-warnings work only with 8, but we do not fail with 11 and this is very
confusing.
As we saw with this ticket, if we do not think how to add something and be
clear when they do not work - we can really miss things are broken.
eclipse-warnings I suspect might be replaced soon but checkstyle is here to
stay. This is my understanding
was (Author: e.dimitrova):
{quote} I've created CASSANDRA-18267)
{quote}
Thanks
{quote}This patch ninja-fixes JdkProperties and fixes the above targets
{quote}
I can confirm that it fixed the issue I was seeing in IDEA yesterday.
eclipse-warnings and checkstyle - I can neither deny, nor confirm they were
broken/fixed/working from the log. When I run them with any jdk they always
finish with "BUILD SUCCESSFUL"
Is there a way to add anything to the logs?
I think I mentioned it before that there is comment that eclipse-warnings work
only with 8, but we do not fail with 11 and this is very confusing.
As we saw with this ticket, if we do not think how to add something and be
clear when they do not work - we can really miss things are broken.
eclipse-warnings I suspect might be replaced soon but checkstyle is here to
stay. This is my understanding
> Update build.xml for experimental JDK17 use
> -------------------------------------------
>
> Key: CASSANDRA-18179
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18179
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Michael Semb Wever
> Priority: Normal
> Fix For: 4.2
>
>
> To support JDK17 we need to make changes to build.xml and our scripts. There
> is a preliminary patch which makes a switch from JDK8+JDK11 to JDK11+JDK17
> but it will need a change considering CASSANDRA-18133
> CC [~mck]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
