[
https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690832#comment-17690832
]
Ekaterina Dimitrova commented on CASSANDRA-18106:
-------------------------------------------------
{quote} java.supported is providing "1.8" instead of just "8.
{quote}
Thanks for spotting it
{quote}Also, trivial, but can we remove the JAVAx_HOME lines (in just trunk):
{quote}
Honestly, we should also take care of CASSANDRA_USE_JDK11
[here|https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L231]
or to be more accurate in config-2_1.yml
One more thing, CCM has its own tests and [JDK
tests|https://github.com/riptano/ccm/blob/master/tests/test_lib.py] also exist.
I know some of the CCM tests had some trouble to be run and Ariel has a
suggested fix that we keep on forgetting (published in CASSANDRA-17861) so
might be a good time to look at that one and then update here also the JDK CCM
tests accordingly.
> Update CCM for JDK17 and revise current JDK detection strategy
> --------------------------------------------------------------
>
> Key: CASSANDRA-18106
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18106
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Brandon Williams
> Priority: Normal
> Fix For: 4.x
>
>
> As part of CASSANDRA-16895 initial POC an initial version of CCM patch was
> created. This needs to be revisited and reviewed
> Recently we closed CASSANDRA-18039 which brought questions, probably we need
> to revise how we detect JDK versions in CCM and whether it is correct. To the
> best of my knowledge there are certain tests in the repo around that and they
> pass so my guess is we need to revise just the strategy and maybe document it
> explicitly or consider if we want any changes to be applied. Also, we need to
> be careful with breaking changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
