[ 
https://issues.apache.org/jira/browse/CASSANDRA-18125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694220#comment-17694220
 ] 

Jon Meredith commented on CASSANDRA-18125:
------------------------------------------

So Benedict has fixed the issues with the code/test as I shared it, but 
unfortunately there was a copy/paste bug in the test that meant complex column 
deletion was not being set on the partition update. Back to failing.

I've pushed recent changes, which resolve these non-test issues

1) our cloning behaviour is broken for complex columns, we don’t clone empty 
byte buffers with cell paths
2) we aren’t counting additional allocations for btree backing arrays when we 
update one leaf with the contents of another leaf
3) if we merge two cells, we copy the contents whether or not they are already 
in the memtable
4) when copying back on heap from memtable during read, if we are off heap, we 
do it at least three times


> AssertionError on thread MemtableReclaimMemory in 
> MemtablePool$SubPool.released(MemtablePool.java:193)
> ------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-18125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18125
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Memtable
>            Reporter: Nicolas Henneaux
>            Assignee: Benedict Elliott Smith
>            Priority: Normal
>             Fix For: 4.0.x, 4.1.x, 4.x
>
>
> On two nodes (on a 5 nodes cluster) on the cluster I'm running, I got the 
> following exception. It occurred at 3,5 minutes interval.
> {code}
> MemtableReclaimMemory:2625 org.apache.cassandra.service.CassandraDaemon 
> uncaughtException - Exception in thread 
> Thread[MemtableReclaimMemory:2625,5,main]java.lang.AssertionError: null
>       at 
> org.apache.cassandra.utils.memory.MemtablePool$SubPool.released(MemtablePool.java:193)
>       at 
> org.apache.cassandra.utils.memory.MemtableAllocator$SubAllocator.releaseAll(MemtableAllocator.java:151)
>       at 
> org.apache.cassandra.utils.memory.MemtableAllocator$SubAllocator.setDiscarded(MemtableAllocator.java:142)
>       at 
> org.apache.cassandra.utils.memory.MemtableAllocator.setDiscarded(MemtableAllocator.java:93)
>       at 
> org.apache.cassandra.utils.memory.SlabAllocator.setDiscarded(SlabAllocator.java:120)
>       at org.apache.cassandra.db.Memtable.setDiscarded(Memtable.java:201)
>       at 
> org.apache.cassandra.db.ColumnFamilyStore$Flush$1.runMayThrow(ColumnFamilyStore.java:1216)
>       at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)
>       at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>       at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>       at 
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
>       at java.base/java.lang.Thread.run(Thread.java:829)
> {code} 
> {code}
> $ nodetool info
> ID                     : 
> Gossip active          : true
> Native Transport active: true
> Load                   : 204.67 GiB
> Generation No          : 1670343179
> Uptime (seconds)       : 1110514
> Heap Memory (MB)       : 7218.07 / 24576.00
> Off Heap Memory (MB)   : 784.06
> Data Center            : par
> Rack                   : e1
> Exceptions             : 1
> Key Cache              : entries 802712, size 100 MiB, capacity 100 MiB, 
> 774541004 hits, 914207516 requests, 0.847 recent hit rate, 14400 save period 
> in seconds
> Row Cache              : entries 0, size 0 bytes, capacity 0 bytes, 0 hits, 0 
> requests, NaN recent hit rate, 0 save period in seconds
> Counter Cache          : entries 0, size 0 bytes, capacity 50 MiB, 0 hits, 0 
> requests, NaN recent hit rate, 7200 save period in seconds
> Percent Repaired       : 2.3272298419424144E-5%
> Token                  : (invoke with -T/--tokens to see all 8 tokens)
> $ java -version
> openjdk version "11.0.16" 2022-07-19 LTS
> OpenJDK Runtime Environment (Red_Hat-11.0.16.0.8-1.el7_9) (build 
> 11.0.16+8-LTS)
> OpenJDK 64-Bit Server VM (Red_Hat-11.0.16.0.8-1.el7_9) (build 11.0.16+8-LTS, 
> mixed mode, sharing)
> $ nodetool version
> ReleaseVersion: 4.0.6
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to