[
https://issues.apache.org/jira/browse/CASSANDRA-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695030#comment-17695030
]
Stefan Miklosovic commented on CASSANDRA-18268:
-----------------------------------------------
Great, [~milan_k] . I took your change and I added minor improvements:
1) I fixed minor things in CompactionManager.parallelAllSSTableOperation while
we are on this.
2) I put this kind of logging to all places in StorageService where we use
CompactionManager operations. There is no reason this should be logged only for
cleanup and garbagecollect
3) I consolidated the names of method parameters for related methods in
StorageService. Somewhere it is "tables", then "tableNames", then
"columnFamilies". Formatting of varags is "String ... name" and somewhere
"String... name". It is all "String... name" everywhere.
Branch: [https://github.com/apache/cassandra/pull/2184]
I ll provide CI when all is fine for everybody.
> Log completed status with cleanup and garbagecollect operations
> ---------------------------------------------------------------
>
> Key: CASSANDRA-18268
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18268
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Logging
> Reporter: Kan Maung
> Assignee: Milan Krisko
> Priority: Normal
>
> Whenever a cleanup or garbagecollect operation is issued from nodetool, there
> is no log statuses for the start and end of the operation at the node level
> although statuses on individual sstables are captured. Start can be inferred,
> but it is difficult to know when the operation has completed because there is
> no log message.
>
> [INFO ] cluster_id=5 ip_address=127.1.1.1 CompactionManager.java:353 -
> Starting Remove deleted data for keyspace1.sstable1
> [INFO ] cluster_id=5 ip_address=127.1.1.1 CompactionManager.java:395 -
> Finished Remove deleted data for keyspace1.sstable1 successfully
> [INFO ] cluster_id=5 ip_address=127.1.1.1 CompactionManager.java:353 -
> Starting Remove deleted data for keyspace1.sstable2
> [INFO ] cluster_id=5 ip_address=127.1.1.1 CompactionManager.java:364 - No
> sstables to GARBAGE_COLLECT for keyspace1.sstable2
> [INFO ] cluster_id=5 ip_address=127.1.1.1 CompactionManager.java:395 -
> Finished Remove deleted data for keyspace1.sstable2 successfully
>
> This improvement proposes adding additional for start and end statuses log
> messages for the above operation at the node level. I.e.,
>
> [INFO ] cluster_id=5 ip_address=127.1.1.1 CompactionManager.java:395 –
> Starting GARBAGE_COLLECT
> ….
> [INFO ] cluster_id=5 ip_address=127.1.1.1 CompactionManager.java:395 –
> Completed GARBAGE_COLLECT
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
