[
https://issues.apache.org/jira/browse/CASSANDRA-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698376#comment-17698376
]
Aleksey Yeschenko commented on CASSANDRA-18304:
-----------------------------------------------
So, {{WriteCallbackInfo}} code is all dead weight and should be removed. Pushed
a commit that does it here:
https://github.com/iamaleksey/cassandra/commits/18304-dead-code-removal
{{allowHints}} argument to some of the upstream methods needs to make its way
to {{AbstractWriteResponseHandler}}, or, alternatively, we need to make sure
that mutation supplier is always null when when {{!allowHints}} and never null
when {{allowHints}}.
> hinted_handoff_enabled=false is not honored
> -------------------------------------------
>
> Key: CASSANDRA-18304
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18304
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Hints
> Reporter: Paulo Motta
> Assignee: Paulo Motta
> Priority: Normal
> Fix For: 4.1.x, 5.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I've had some dtests with disabled hints failing.
> After investigation it seems that CASSANDRA-17164 moved hint submission on
> timeout from
> [RequestCallbacks.onExpired|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-b73c13ea8cae91a215495917fe5e90d55c9f4a283f9e053110992bc9a60004b8L176]
> to
> [AbstractWriteResponseHandler.onFailure|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-3b202de0d077638bede7bf4076a15eb4d483b717f955f11e743efb8d27c6eb1dR285],
> but it no longer checks if {{CallbackInfo.shouldHint}} which checks for
> {{StorageProxy.shouldHint}} which ultimately checks if
> {{{}hinted_handoff_enabled=true{}}}.
> This could cause some tests which expect hints to be disabled to fail
> intermittently.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
