[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698634#comment-17698634
]
Ekaterina Dimitrova commented on CASSANDRA-18239:
-------------------------------------------------
All good ideas and I would be also happy to see eclipse warnings replaced by
something better.
Currently we are trying to put everything into place for JDK17. Lots of moving
parts. We need to ensure we have eclipse warnings or whatever else we want to
perform the analysis with JDK11 so we can drop JDK8. So my ask here is either
we enable a replacement of eclipse-warnings (if it doesn't take months) and do
further improvements in follow up tickets or we switch eclipse warnings to be
run with JDK11 so we do not block for long the drop of JDK8.
I also found a comment in build.xml:
[<!-- ECJ 4.6.1 in standalone mode does not work with JPMS, so we skip this
target for Java 11
-->|https://github.com/apache/cassandra/blob/trunk/build.xml#L1909]
> Replace eclipse warnings based static code analysis with something better
> (Sonar)
> ---------------------------------------------------------------------------------
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Jacek Lewandowski
> Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
