[ https://issues.apache.org/jira/browse/CASSANDRA-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Capwell updated CASSANDRA-18309: -------------------------------------- Fix Version/s: 5.0 (was: 5.x) Since Version: 5.0 Source Control Link: https://github.com/apache/cassandra/commit/51b0dca71df94631519fdf1639aeb5f9ba43c570 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Remove git hook for pre-push as it is redundant and causes issues when > merging to mainline > ------------------------------------------------------------------------------------------ > > Key: CASSANDRA-18309 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18309 > Project: Cassandra > Issue Type: Bug > Components: Accord > Reporter: David Capwell > Assignee: David Capwell > Priority: Normal > Fix For: 5.0 > > > {code} > [cep-15-accord][~/repos/apache-cassandra]$ git push origin cep-15-accord > Warning: Permanently added 'github.com' (ED25519) to the list of known hosts. > Entering 'modules/accord' > Username for 'https://github.com': > {code} > This is caused by .build/git/git-hooks/pre-push/100-push-submodules.sh logic > {code} > local -r cmd=' > branch="$(git rev-parse --abbrev-ref HEAD)" > [[ "$branch" == "HEAD" ]] && exit 0 > default_remote="$(git config --local --get branch."${branch}".remote || true)" > remote="${default_remote:-origin}" > git push --atomic "$remote" "$branch" > ' > git submodule foreach --recursive "$cmd" > {code} > This logic was to make sure that the submodule is pushed before you push your > changes, but this is slightly redundant as > .build/git/git-hooks/pre-commit/100-verify-submodules-pushed.sh will not > allow you to commit the submodule SHA until it can confirm its on GitHub. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org