[
https://issues.apache.org/jira/browse/CASSANDRA-18247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701298#comment-17701298
]
Ekaterina Dimitrova commented on CASSANDRA-18247:
-------------------------------------------------
Thank you for the quick review!
{quote}handling config.yml in the script?
{quote}
I thought it might be more confusing when updating the new set of configuration
files - we all of a sudden to update also config.yml directly from
generate_11_and_17.sh. That is why I also added
[this|https://github.com/apache/cassandra/commit/88dc2a6c7690472d78b428384793e383f37499dc#diff-6fcd5ddc6b9f5c68d75973fc034bd038f6ed5d6a064ae834d4b490b4a211f7deR139]
and
[this|https://github.com/apache/cassandra/commit/88dc2a6c7690472d78b428384793e383f37499dc#diff-6fcd5ddc6b9f5c68d75973fc034bd038f6ed5d6a064ae834d4b490b4a211f7deR147]
message to the output when using the -f and -p flags.
{quote}I think if I'm running the script to generate that config it's probably
what I'm going to use most of the time, and if I need to go back I can just run
generate.sh over it.
{quote}
Indeed, this is second option but I got worried people will forget to do it and
it can easily become a mess in the cassandra repo. Someone will commit the
switch to 11+17 by mistake earlier than we want it. :) Otherwise it would have
followed the flow of the other flags usage - do not go and update config.yml
directly when using them.
> Add CircleCI config files for J11+J17
> -------------------------------------
>
> Key: CASSANDRA-18247
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18247
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Based on the direction of [this
> discussion|https://lists.apache.org/thread/hchv59c1sntgb74clynj0zfd8jvwdmgy],
> I would like to propose CircleCI config files which can be used to test
> current trunk with JDK 17 (after I blindly remove the scripted UDFs in
> another ticket, to be opened soon)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
