[
https://issues.apache.org/jira/browse/CASSANDRA-17161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701324#comment-17701324
]
Ekaterina Dimitrova edited comment on CASSANDRA-17161 at 3/16/23 6:10 PM:
--------------------------------------------------------------------------
bq. Could you elaborate more on these few parameters? Which are they?
All other parameters marked with @Deprecated in Config class.
But I believe that since I opened this ticket there were discussions in time
about removal of yaml configuration parameters(whether we can fully remove them
even in major version or they should stay dead code, marked @Deprecated in
Config to support easier upgrades). I haven't seen myself final decision made.
Recommendation for whoever assigns the ticket: Please bring a list of planned
cassandra.yaml configuration parameters for removal to the ML for approval
before submitting a patch.
was (Author: e.dimitrova):
bq. Could you elaborate more on these few parameters? Which are they?
All other parameters marked with @Deprecated in Config class.
But I believe that since I opened this ticket there were discussions in time
about removal of yaml configuration parameters(whether we can fully remove them
even in major version or they should stay dead code, marked @Deprecated in
Config to support easier upgrades). I haven't seen myself final decision made.
Recommendation for whoever assigns the ticket: Please bring a list of planned
configuration parameters for removal to the ML for approval before submitting a
patch.
> Remove commitlog_sync_batch_window_in_ms
> ----------------------------------------
>
> Key: CASSANDRA-17161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17161
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.x
>
>
> commitlog_sync_batch_window_in_ms is deprecated in 4.0 and has to be removed
> in 5.0
> This will require also some work around the in-jvm upgrade tests.
> Currently they do not work if we remove a parameter in a later version.
> Side note: They also don't work if we change the type of the parameter in
> Config class in a newer Cassandra version. If you plan to set it in the tests
> themselves, it won't work. If you change the type but your don't set the
> parameter, no issue so there might be some workaround solution instead of
> working on the dtest framework itself.... TBD
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
