[
https://issues.apache.org/jira/browse/CASSANDRA-18049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703268#comment-17703268
]
Ekaterina Dimitrova edited comment on CASSANDRA-18049 at 3/21/23 4:09 PM:
--------------------------------------------------------------------------
{quote}Only comments have been added to the patch since the last runs (which
includes circleci jdk17) 🤷🏻♀️
{quote}
Correct, there were also not many changes in trunk in those 5 days since it was
run. You are right.
J8+J11 run is all green; J11+J17 match the current snapshot of failures with
J17, published in the CASSANDRA-16895 ticket description. The respective
tickets for those failures can be also found there.
+1 to squash the comments and commit the patch to trunk. Thank you
And about:
{quote} - introduced (but not used yet), the default sync to disk mode for
chronicle-bytes is async, ref
[MappedBytesStore.java|https://github.com/OpenHFT/Chronicle-Bytes/blob/chronicle-bytes-2.23.33/src/main/java/net/openhft/chronicle/bytes/MappedBytesStore.java#L49]
-- if the user configures audit or fql logging to be blocking should we then
set {{SyncMode.SYNC}} ?
-- alternatively, if the user wants blocking AND paranoid disk sync, they can
manually set `{{{}-DmappedFile.defaultSyncMode=SYNC{}}}` (and we should
document this in cassandra.yaml){quote}
I suggest we open a follow up ticket for exploring to make the default sync
configurable from the yaml or just document it with some recommendation, etc.
(If I understood you correctly)
was (Author: e.dimitrova):
{quote}Only comments have been added to the patch since the last runs (which
includes circleci jdk17) 🤷🏻♀️
{quote}
Correct, there were also not many changes in trunk in those 5 days since it was
run. You are right.
J8+J11 run is all green; J11+J17 match the current snapshot of failures with
J17, published in the CASSANDRA-16895 ticket description. The respective
tickets for those failures can be also found there.
+1 to squash the comments and commit the patch to trunk.
And about:
{quote} - introduced (but not used yet), the default sync to disk mode for
chronicle-bytes is async, ref
[MappedBytesStore.java|https://github.com/OpenHFT/Chronicle-Bytes/blob/chronicle-bytes-2.23.33/src/main/java/net/openhft/chronicle/bytes/MappedBytesStore.java#L49]
-- if the user configures audit or fql logging to be blocking should we then
set {{SyncMode.SYNC}} ?
-- alternatively, if the user wants blocking AND paranoid disk sync, they can
manually set `{{{}-DmappedFile.defaultSyncMode=SYNC{}}}` (and we should
document this in cassandra.yaml){quote}
I suggest we open a follow up ticket for exploring to make the default sync
configurable from the yaml or just document it with some recommendation, etc.
(If I understood you correctly)
> Update Chronicle Queue
> ----------------------
>
> Key: CASSANDRA-18049
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18049
> Project: Cassandra
> Issue Type: Task
> Reporter: Ekaterina Dimitrova
> Assignee: Michael Semb Wever
> Priority: Normal
> Fix For: 5.x
>
>
> According to [this|https://chronicle.software/chronicle-support-java-17]
> article:
> {code:java}
> Starting from chronicle-bom-2.22ea26, all new releases can be run under Java
> 17 when run on the class path (but not yet under the module path).{code}
> This BOM is newer than what we currently have in both 4.1 and trunk. 4.1
> points in comments to
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/1.16.23] which
> I believe was just forgotten to be updated/removed. The versions we see
> correspond to this BOM
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/2.20.226]
> It is still older than chronicle-bom-2.22ea26 so we need to upgrade. I
> suggest we also add a comment again which BOM is considered, this makes
> things easier.
> Further to running CI, review of the CHANGE logs needs to happen to ensure we
> do not miss anything that can impact us and it is not caught by our tests.
> For testing with JDK17, please, contact [~e.dimitrova] for latest branch and
> CI config (at this point feature branch in the cassandra repo does not exist)
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
