[ https://issues.apache.org/jira/browse/CASSANDRA-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708444#comment-17708444 ]
Ekaterina Dimitrova edited comment on CASSANDRA-18395 at 4/4/23 2:20 PM: ------------------------------------------------------------------------- Hi [~slachiewicz], Thank you for testing, raising a ticket, and submitting a patch! Truly appreciate the effort! Currently the plan for Cassandra 5.0 is to be shipped with JDK11 builds which can be run with 11 and 17 (experimental at first). I believe this patch is not needed for supporting JDK17? With that said, I will remove it from the JDK17 epic. It is needed for efforts to bring Cassandra to future versions, It is not a blocker for JDK17. Upgrading to newer JDK versions is/will be a continuous community effort. So I see this ticket as valuable and thank you once again for looking into it! Someone with cycles will take a look at it (CI run needed, etc) but it is not a blocker for JDK17 so it might not be immediate priority to commit it. was (Author: e.dimitrova): Hi [~slachiewicz], Thank you for testing, raising a ticket, and submitting a patch! Truly appreciate the effort! Currently the plan for Cassandra 5.0 is to be shipped with JDK11 builds which can be run with 11 and 17 (experimental at first). I believe this patch is not needed for supporting JDK17? With that said, I will remove it from the JDK17 epic but it is needed for efforts to bring Cassandra to future versions. It is not a blocker for JDK17. Upgrading to newer JDK versions is/will be a continuous community effort. So I see this ticket as valuable and thank you once again for looking into it! Someone with cycles will take a look at it (CI run needed, etc) but it is not a blocker for JDK17 so it might not be immediate priority to commit it. > Rename internal state() method in AbstractFuture to not conflict with Java 19 > changes > ------------------------------------------------------------------------------------- > > Key: CASSANDRA-18395 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18395 > Project: Cassandra > Issue Type: Bug > Components: Build > Reporter: Sylwester Lachiewicz > Assignee: Sylwester Lachiewicz > Priority: Normal > Fix For: 6.x > > > From Java 19 we have new method Future.state and it conflicts with our > private method. Fix bellow. > [https://download.java.net/java/early_access/jdk20/docs/api/java.base/java/util/concurrent/Future.html#state()] > > {code:java} > +++ b/src/java/org/apache/cassandra/utils/concurrent/AbstractFuture.java > @@ -494,11 +494,11 @@ public abstract class AbstractFuture<V> implements > Future<V> > public String toString() > { > String description = description(); > - String state = state(); > + String state = stateInfo(); > return description == null ? state : (state + ' ' + description); > } > > - private String state() > + private String stateInfo() > { > Object result = this.result; > if (isSuccess(result)){code} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org